wenxuwan commented on a change in pull request #1045:
URL: https://github.com/apache/dubbo-go/pull/1045#discussion_r571593524
##########
File path: protocol/dubbo/dubbo_invoker.go
##########
@@ -123,18 +138,22 @@ func (di *DubboInvoker) Invoke(ctx context.Context,
invocation protocol.Invocati
//response := NewResponse(inv.Reply(), nil)
rest := &protocol.RPCResult{}
timeout := di.getTimeout(inv)
- if async {
- if callBack, ok := inv.CallBack().(func(response
common.CallbackResponse)); ok {
- //result.Err =
di.client.AsyncCall(NewRequest(url.Location, url, inv.MethodName(),
inv.Arguments(), inv.Attachments()), callBack, response)
- result.Err = di.client.AsyncRequest(&invocation, url,
timeout, callBack, rest)
- } else {
- result.Err = di.client.Send(&invocation, url, timeout)
- }
+ client := di.getClient()
Review comment:
getClient返回的是client指针，下面关闭的时候，同样会把这个client赋值为nil
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
