gaoxinge commented on a change in pull request #1010:
URL: https://github.com/apache/dubbo-go/pull/1010#discussion_r587096223
##########
File path: protocol/dubbo/dubbo_invoker.go
##########
@@ -196,8 +196,12 @@ func (di *DubboInvoker) Destroy() {
di.BaseInvoker.Destroy()
client := di.getClient()
if client != nil {
+ activeNumber := client.DecreaseActiveNumber()
di.setClient(nil)
- client.Close()
+ if activeNumber == 0 {
Review comment:
(1) close the conn until all the invokers (in one Node(VM)) destroyed
(2) close the conn if active number is zero
- So now codes seems to implement the (2), not (1)? Or
- Does (1) equal to (2)?
I am not sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
