zouyx commented on a change in pull request #1076:
URL: https://github.com/apache/dubbo-go/pull/1076#discussion_r590448665
##########
File path: go.mod
##########
@@ -54,6 +54,9 @@ require (
replace (
github.com/coreos/bbolt => go.etcd.io/bbolt v1.3.4
+ github.com/dubbogo/gost => github.com/wenxuwan/gost
v1.9.4-0.20210309022905-7993b30b1a7d
Review comment:
is it right replacment?
##########
File path: remoting/etcdv3/listener_test.go
##########
@@ -18,17 +18,24 @@
package etcdv3
import (
+ "net/url"
+ "os"
+ "testing"
"time"
)
import (
+ "github.com/coreos/etcd/embed"
+ gxetcd "github.com/dubbogo/gost/database/kv/etcd/v3"
"github.com/stretchr/testify/assert"
)
import (
"github.com/apache/dubbo-go/remoting"
)
+const defaultEtcdV3WorkDir = "/tmp/default-dubbo-go-remote.etcd"
Review comment:
will it cause problem in docker env? like access deny , can not open
file etc?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
