LaurenceLiZhixin commented on a change in pull request #1030:
URL: https://github.com/apache/dubbo-go/pull/1030#discussion_r593896295



##########
File path: config/base_config.go
##########
@@ -50,6 +50,9 @@ type BaseConfig struct {
        EventDispatcherType string        `default:"direct" 
yaml:"event_dispatcher_type" json:"event_dispatcher_type,omitempty"`
        MetricConfig        *MetricConfig `yaml:"metrics" 
json:"metrics,omitempty"`
        fileStream          *bytes.Buffer
+
+       // cache file used to store the current used configurations.
+       CacheFile string `yaml:"cache_file" json:"cache_file,omitempty" 
property:"cache_file"`

Review comment:
       Yes, you write provider config to CacheFile, but I want to know where to 
use it. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to