AlexStocks commented on a change in pull request #1071: URL: https://github.com/apache/dubbo-go/pull/1071#discussion_r595911791
########## File path: protocol/dubbo3/dubbo3_protocol.go ########## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package dubbo3 + +import ( + "fmt" + tripleCommon "github.com/dubbogo/triple/pkg/common" + "reflect" + "sync" +) + +import ( + dubbo3 "github.com/dubbogo/triple/pkg/triple" + "google.golang.org/grpc" +) + +import ( + "github.com/apache/dubbo-go/common" + "github.com/apache/dubbo-go/common/constant" + "github.com/apache/dubbo-go/common/extension" + "github.com/apache/dubbo-go/common/logger" + "github.com/apache/dubbo-go/config" + "github.com/apache/dubbo-go/protocol" +) + +const ( + // DUBBO3 is dubbo3 protocol name + DUBBO3 = "dubbo3" +) + +var protocolOnce sync.Once + +func init() { + extension.SetProtocol(DUBBO3, GetProtocol) + protocolOnce = sync.Once{} +} + +var ( + dubboProtocol *DubboProtocol +) + +// It support dubbo protocol. It implements Protocol interface for dubbo protocol. +type DubboProtocol struct { + protocol.BaseProtocol + serverLock sync.Mutex + serverMap map[string]*dubbo3.TripleServer // It is store relationship about serviceKey(group/interface:version) and ExchangeServer +} + +// NewDubboProtocol create a dubbo protocol. +func NewDubboProtocol() *DubboProtocol { + return &DubboProtocol{ + BaseProtocol: protocol.NewBaseProtocol(), + serverMap: make(map[string]*dubbo3.TripleServer), + } +} + +// Export export dubbo3 service. +func (dp *DubboProtocol) Export(invoker protocol.Invoker) protocol.Exporter { + url := invoker.GetUrl() + serviceKey := url.ServiceKey() + exporter := NewDubboExporter(serviceKey, invoker, dp.ExporterMap()) + dp.SetExporterMap(serviceKey, exporter) + logger.Infof("Export service: %s", url.String()) + // start server + + dp.openServer(url) + return exporter +} + +// Refer create dubbo3 service reference. +func (dp *DubboProtocol) Refer(url *common.URL) protocol.Invoker { + invoker, err := NewDubboInvoker(url) + if err != nil { + logger.Errorf("Refer url = %+v, with error = %s", url, err.Error()) + return nil + } + dp.SetInvokers(invoker) + logger.Infof("Refer service: %s", url.String()) + return invoker +} + +// Destroy destroy dubbo3 service. +func (dp *DubboProtocol) Destroy() { + dp.BaseProtocol.Destroy() + + // stop server + for key, server := range dp.serverMap { Review comment: 不提倡在 map for 循环中删除map，你能换一种写法吗？ ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
