wenxuwan commented on a change in pull request #1137:
URL: https://github.com/apache/dubbo-go/pull/1137#discussion_r608742834
##########
File path: remoting/zookeeper/listener.go
##########
@@ -182,7 +182,7 @@ func (l *ZkEventListener) handleZkNodeEvent(zkPath string,
children []string, li
logger.Warnf("delete zkNode{%s}", node)
listener.DataChange(remoting.Event{Path: node,
Action: remoting.EventTypeDel})
l.pathMapLock.Lock()
- delete(l.pathMap, zkPath)
+ delete(l.pathMap, node)
Review comment:
In my opinion ,here and below don't need delete logic. There have a
goroutine do this(Line 310), please check it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
