[GitHub] [dubbo-go] jack15083 commented on a change in pull request #1157: Fix:delete a service provider when using k8s hpa (3.0)

Wed, 14 Apr 2021 20:32:35 -0700 


jack15083 commented on a change in pull request #1157:
URL: https://github.com/apache/dubbo-go/pull/1157#discussion_r613732638



##########
File path: common/url.go
##########
@@ -344,6 +344,16 @@ func (c *URL) Key() string {
        return buildString
 }
 
+//CacheInvokerMapKey get dir cacheInvokerMap key
+func (c *URL) CacheInvokerMapKey() string {
+       urlNew, _ := NewURL(c.PrimitiveURL)

Review comment:
       这里加上这一段只是为了获取通知里timestamp，因为这里的c用的旧的invoker url 
的参数，看下图的逻辑，执行了common.MergeURL(url, referenceUrl) 会将新url的参数给覆盖掉，不清楚为啥要执行这一步merge
   
   
![image](https://user-images.githubusercontent.com/2142066/114810062-ea598280-9ddd-11eb-95a5-b06109b28c53.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to