AlexStocks commented on a change in pull request #1161:
URL: https://github.com/apache/dubbo-go/pull/1161#discussion_r615305917
##########
File path: metadata/identifier/subscribe_metadata_identifier.go
##########
@@ -32,3 +47,18 @@ func (mdi *SubscriberMetadataIdentifier) GetIdentifierKey()
string {
func (mdi *SubscriberMetadataIdentifier) GetFilePathKey() string {
return mdi.BaseMetadataIdentifier.getFilePathKey(mdi.Revision)
}
+
+func NewSubscriberMetadataIdentifier(application string, revision string)
*SubscriberMetadataIdentifier {
+ return &SubscriberMetadataIdentifier{
+ Revision: revision,
+ MetadataIdentifier: MetadataIdentifier{
+ Application: application,
+ BaseMetadataIdentifier: BaseMetadataIdentifier{
+ ServiceInterface: "",
Review comment:
hey, guy, pls remember that, if its default value is "", u need not to
assign the same value to it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
