wongoo commented on a change in pull request #264: URL: https://github.com/apache/dubbo-go-hessian2/pull/264#discussion_r615356520
########## File path: java_util/locale.go ########## @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package java_util + +import "fmt" + +// LocaleEnum is Locale enumeration value +type LocaleEnum int + +// Locale object enum +const ( + ROOT LocaleEnum = iota + ENGLISH + FRENCH + GERMAN + ITALIAN + JAPANESE + KOREAN + CHINESE + SIMPLIFIED_CHINESE + TRADITIONAL_CHINESE + FRANCE + GERMANY + ITALY + JAPAN + KOREA + CHINA + PRC + TAIWAN + UK + US + CANADA + CANADA_FRENCH +) + +// Locale => java.util.Locale +type Locale struct { + // ID is used to implement enumeration + id LocaleEnum + Lang string + County string +} + +func (locale *Locale) String() string { + if len(locale.County) != 0 { + return fmt.Sprintf("%s_%s", locale.Lang, locale.County) + } + return locale.Lang +} + +// LocaleHandle => com.alibaba.com.caucho.hessian.io.LocaleHandle object +type LocaleHandle struct { + Value string `hessian:"value"` +} + +func (LocaleHandle) JavaClassName() string { + return "com.alibaba.com.caucho.hessian.io.LocaleHandle" +} + +var locales []Locale = make([]Locale, 22, 22) + +// init java.util.Locale static object +func init() { + // Useful constant for language. + var ENGLISH = Locale{ + id: ENGLISH, + Lang: "en", + County: "", + } + // Useful constant for language. + var FRENCH = Locale{ + id: FRENCH, + Lang: "fr", + County: "", + } + // Useful constant for language. + var GERMAN = Locale{ + id: GERMAN, + Lang: "de", + County: "", + } + // Useful constant for language. + var ITALIAN = Locale{ + id: ITALIAN, + Lang: "it", + County: "", + } + // Useful constant for language. + var JAPANESE = Locale{ + id: JAPANESE, + Lang: "ja", + County: "", + } + // Useful constant for language. + var KOREAN = Locale{ + id: KOREAN, + Lang: "ko", + County: "", + } + // Useful constant for language. + var CHINESE = Locale{ + id: CHINESE, + Lang: "zh", + County: "", + } + // Useful constant for language. + var SIMPLIFIED_CHINESE = Locale{ + id: SIMPLIFIED_CHINESE, + Lang: "zh", + County: "CN", + } + // Useful constant for language. + var TRADITIONAL_CHINESE = Locale{ + id: TRADITIONAL_CHINESE, + Lang: "zh", + County: "TW", + } + // Useful constant for language. + var FRANCE = Locale{ + id: FRANCE, + Lang: "fr", + County: "FR", + } + // Useful constant for language. + var GERMANY = Locale{ + id: GERMANY, + Lang: "de", + County: "DE", + } + // Useful constant for language. + var ITALY = Locale{ + id: ITALY, + Lang: "it", + County: "it", + } + // Useful constant for language. + var JAPAN = Locale{ + id: JAPAN, + Lang: "ja", + County: "JP", + } + // Useful constant for language. + var KOREA = Locale{ + id: KOREA, + Lang: "ko", + County: "KR", + } + // Useful constant for language. + var CHINA = SIMPLIFIED_CHINESE + // Useful constant for language. + var PRC = SIMPLIFIED_CHINESE + // Useful constant for language. + var TAIWAN = TRADITIONAL_CHINESE + // Useful constant for language. + var UK = Locale{ + id: UK, + Lang: "en", + County: "GB", + } + // Useful constant for language. + var US = Locale{ + id: US, + Lang: "en", + County: "US", + } + // Useful constant for language. + var CANADA = Locale{ + id: CANADA, + Lang: "en", + County: "CA", + } + // Useful constant for language. + var CANADA_FRENCH = Locale{ + id: CANADA_FRENCH, + Lang: "fr", + County: "CA", + } + // Useful constant for language. + var ROOT = Locale{ + id: ROOT, + Lang: "", + County: "", + } + locales = append(locales, ENGLISH, FRENCH, GERMAN, ITALIAN, JAPANESE, KOREAN, CHINESE, SIMPLIFIED_CHINESE, TRADITIONAL_CHINESE, FRANCE, + GERMANY, ITALY, JAPAN, KOREA, CHINA, PRC, TAIWAN, UK, US, CANADA, CANADA_FRENCH, ROOT) +} + +// GetLocale is use enum value get Locale, +// default value is ROOT +func GetLocale(localeEnum LocaleEnum) *Locale { + // Useful constant for language. + var ROOT = Locale{ + id: 22, + Lang: "", + County: "", + } + for _, locale := range locales { + if localeEnum == CHINA || localeEnum == PRC { Review comment: check first at the beginning of the func ########## File path: java_util/locale.go ########## @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package java_util + +import "fmt" + +// LocaleEnum is Locale enumeration value +type LocaleEnum int + +// Locale object enum +const ( + ROOT LocaleEnum = iota + ENGLISH + FRENCH + GERMAN + ITALIAN + JAPANESE + KOREAN + CHINESE + SIMPLIFIED_CHINESE + TRADITIONAL_CHINESE + FRANCE + GERMANY + ITALY + JAPAN + KOREA + CHINA + PRC + TAIWAN + UK + US + CANADA + CANADA_FRENCH +) + +// Locale => java.util.Locale +type Locale struct { + // ID is used to implement enumeration + id LocaleEnum + Lang string + County string +} + +func (locale *Locale) String() string { + if len(locale.County) != 0 { + return fmt.Sprintf("%s_%s", locale.Lang, locale.County) + } + return locale.Lang +} + +// LocaleHandle => com.alibaba.com.caucho.hessian.io.LocaleHandle object +type LocaleHandle struct { + Value string `hessian:"value"` +} + +func (LocaleHandle) JavaClassName() string { + return "com.alibaba.com.caucho.hessian.io.LocaleHandle" +} + +var locales []Locale = make([]Locale, 22, 22) + +// init java.util.Locale static object +func init() { + // Useful constant for language. + var ENGLISH = Locale{ + id: ENGLISH, + Lang: "en", + County: "", + } + // Useful constant for language. + var FRENCH = Locale{ + id: FRENCH, + Lang: "fr", + County: "", + } + // Useful constant for language. + var GERMAN = Locale{ + id: GERMAN, + Lang: "de", + County: "", + } + // Useful constant for language. + var ITALIAN = Locale{ + id: ITALIAN, + Lang: "it", + County: "", + } + // Useful constant for language. + var JAPANESE = Locale{ + id: JAPANESE, + Lang: "ja", + County: "", + } + // Useful constant for language. + var KOREAN = Locale{ + id: KOREAN, + Lang: "ko", + County: "", + } + // Useful constant for language. + var CHINESE = Locale{ + id: CHINESE, + Lang: "zh", + County: "", + } + // Useful constant for language. + var SIMPLIFIED_CHINESE = Locale{ + id: SIMPLIFIED_CHINESE, + Lang: "zh", + County: "CN", + } + // Useful constant for language. + var TRADITIONAL_CHINESE = Locale{ + id: TRADITIONAL_CHINESE, + Lang: "zh", + County: "TW", + } + // Useful constant for language. + var FRANCE = Locale{ + id: FRANCE, + Lang: "fr", + County: "FR", + } + // Useful constant for language. + var GERMANY = Locale{ + id: GERMANY, + Lang: "de", + County: "DE", + } + // Useful constant for language. + var ITALY = Locale{ + id: ITALY, + Lang: "it", + County: "it", + } + // Useful constant for language. + var JAPAN = Locale{ + id: JAPAN, + Lang: "ja", + County: "JP", + } + // Useful constant for language. + var KOREA = Locale{ + id: KOREA, + Lang: "ko", + County: "KR", + } + // Useful constant for language. + var CHINA = SIMPLIFIED_CHINESE + // Useful constant for language. + var PRC = SIMPLIFIED_CHINESE + // Useful constant for language. + var TAIWAN = TRADITIONAL_CHINESE + // Useful constant for language. + var UK = Locale{ + id: UK, + Lang: "en", + County: "GB", + } + // Useful constant for language. + var US = Locale{ + id: US, + Lang: "en", + County: "US", + } + // Useful constant for language. + var CANADA = Locale{ + id: CANADA, + Lang: "en", + County: "CA", + } + // Useful constant for language. + var CANADA_FRENCH = Locale{ + id: CANADA_FRENCH, + Lang: "fr", + County: "CA", + } + // Useful constant for language. + var ROOT = Locale{ + id: ROOT, + Lang: "", + County: "", + } + locales = append(locales, ENGLISH, FRENCH, GERMAN, ITALIAN, JAPANESE, KOREAN, CHINESE, SIMPLIFIED_CHINESE, TRADITIONAL_CHINESE, FRANCE, + GERMANY, ITALY, JAPAN, KOREA, CHINA, PRC, TAIWAN, UK, US, CANADA, CANADA_FRENCH, ROOT) +} + +// GetLocale is use enum value get Locale, +// default value is ROOT +func GetLocale(localeEnum LocaleEnum) *Locale { + // Useful constant for language. + var ROOT = Locale{ Review comment: define root as const？ ########## File path: java_util/locale.go ########## @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package java_util + +import "fmt" + +// LocaleEnum is Locale enumeration value +type LocaleEnum int + +// Locale object enum +const ( + ROOT LocaleEnum = iota + ENGLISH + FRENCH + GERMAN + ITALIAN + JAPANESE + KOREAN + CHINESE + SIMPLIFIED_CHINESE + TRADITIONAL_CHINESE + FRANCE + GERMANY + ITALY + JAPAN + KOREA + CHINA + PRC + TAIWAN + UK + US + CANADA + CANADA_FRENCH +) + +// Locale => java.util.Locale +type Locale struct { + // ID is used to implement enumeration + id LocaleEnum + Lang string + County string +} + +func (locale *Locale) String() string { + if len(locale.County) != 0 { + return fmt.Sprintf("%s_%s", locale.Lang, locale.County) + } + return locale.Lang +} + +// LocaleHandle => com.alibaba.com.caucho.hessian.io.LocaleHandle object +type LocaleHandle struct { + Value string `hessian:"value"` +} + +func (LocaleHandle) JavaClassName() string { + return "com.alibaba.com.caucho.hessian.io.LocaleHandle" +} + +var locales []Locale = make([]Locale, 22, 22) + +// init java.util.Locale static object +func init() { + // Useful constant for language. + var ENGLISH = Locale{ + id: ENGLISH, + Lang: "en", + County: "", + } + // Useful constant for language. + var FRENCH = Locale{ + id: FRENCH, + Lang: "fr", + County: "", + } + // Useful constant for language. + var GERMAN = Locale{ + id: GERMAN, + Lang: "de", + County: "", + } + // Useful constant for language. + var ITALIAN = Locale{ + id: ITALIAN, + Lang: "it", + County: "", + } + // Useful constant for language. + var JAPANESE = Locale{ + id: JAPANESE, + Lang: "ja", + County: "", + } + // Useful constant for language. + var KOREAN = Locale{ + id: KOREAN, + Lang: "ko", + County: "", + } + // Useful constant for language. + var CHINESE = Locale{ + id: CHINESE, + Lang: "zh", + County: "", + } + // Useful constant for language. + var SIMPLIFIED_CHINESE = Locale{ + id: SIMPLIFIED_CHINESE, + Lang: "zh", + County: "CN", + } + // Useful constant for language. + var TRADITIONAL_CHINESE = Locale{ + id: TRADITIONAL_CHINESE, + Lang: "zh", + County: "TW", + } + // Useful constant for language. + var FRANCE = Locale{ + id: FRANCE, + Lang: "fr", + County: "FR", + } + // Useful constant for language. + var GERMANY = Locale{ + id: GERMANY, + Lang: "de", + County: "DE", + } + // Useful constant for language. + var ITALY = Locale{ + id: ITALY, + Lang: "it", + County: "it", + } + // Useful constant for language. + var JAPAN = Locale{ + id: JAPAN, + Lang: "ja", + County: "JP", + } + // Useful constant for language. + var KOREA = Locale{ + id: KOREA, + Lang: "ko", + County: "KR", + } + // Useful constant for language. + var CHINA = SIMPLIFIED_CHINESE + // Useful constant for language. + var PRC = SIMPLIFIED_CHINESE + // Useful constant for language. + var TAIWAN = TRADITIONAL_CHINESE + // Useful constant for language. + var UK = Locale{ + id: UK, + Lang: "en", + County: "GB", + } + // Useful constant for language. + var US = Locale{ + id: US, + Lang: "en", + County: "US", + } + // Useful constant for language. + var CANADA = Locale{ + id: CANADA, + Lang: "en", + County: "CA", + } + // Useful constant for language. + var CANADA_FRENCH = Locale{ + id: CANADA_FRENCH, + Lang: "fr", + County: "CA", + } + // Useful constant for language. + var ROOT = Locale{ + id: ROOT, + Lang: "", + County: "", + } + locales = append(locales, ENGLISH, FRENCH, GERMAN, ITALIAN, JAPANESE, KOREAN, CHINESE, SIMPLIFIED_CHINESE, TRADITIONAL_CHINESE, FRANCE, + GERMANY, ITALY, JAPAN, KOREA, CHINA, PRC, TAIWAN, UK, US, CANADA, CANADA_FRENCH, ROOT) +} + +// GetLocale is use enum value get Locale, +// default value is ROOT +func GetLocale(localeEnum LocaleEnum) *Locale { + // Useful constant for language. + var ROOT = Locale{ + id: 22, + Lang: "", + County: "", + } + for _, locale := range locales { + if localeEnum == CHINA || localeEnum == PRC { + return GetLocale(SIMPLIFIED_CHINESE) + } + if localeEnum == TAIWAN { + return GetLocale(TRADITIONAL_CHINESE) + } + if localeEnum == locale.id { + return &locale + } + } + return &ROOT +} + +// GetLocaleFromHandler is use LocaleHandle get Locale +func GetLocaleFromHandler(localeHandler *LocaleHandle) *Locale { + // Useful constant for language. + var ROOT = Locale{ + id: 22, + Lang: "", + County: "", + } + for _, locale := range locales { + if localeHandler.Value == locale.String() { + return &locale + } + } + return &ROOT Review comment: define ROOT as const -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
