AlexStocks commented on a change in pull request #158:
URL: https://github.com/apache/dubbo-go-pixiu/pull/158#discussion_r619730024
##########
File path: pkg/config/config_load.go
##########
@@ -84,25 +84,53 @@ func YAMLConfigLoad(path string) *model.Bootstrap {
log.Fatalln("[config] [yaml load] load config failed, ", err)
}
cfg := &model.Bootstrap{}
-
bytes, err := yaml.YAMLToJSON(content)
if err != nil {
log.Fatalln("[config] [yaml load] convert YAML to JSON failed,
", err)
}
-
err = json.Unmarshal(bytes, cfg)
if err != nil {
log.Fatalln("[config] [yaml load] yaml unmarshal config failed,
", err)
}
+ adapter(cfg)
+ return cfg
+}
- // other adapter
+// DefaultConfigLoad if not config, will load this
+func DefaultConfigLoad(path string) *model.Bootstrap {
+ log.Println("load config from : ", path)
Review comment:
log.debug?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
