AlexStocks commented on a change in pull request #159:
URL: https://github.com/apache/dubbo-go-pixiu/pull/159#discussion_r619829067
##########
File path: cmd/pixiu/control.go
##########
@@ -18,6 +18,7 @@
package main
import (
+ "github.com/apache/dubbo-go-pixiu/pkg/model"
Review comment:
move it to the 3rd import block.
##########
File path: cmd/pixiu/control.go
##########
@@ -133,3 +97,47 @@ var (
},
}
)
+
+func PixiuAction(c *cli.Context) error {
+ configPath := c.String("config")
+ apiConfigPath := c.String("api-config")
+ flagLogLevel := c.String("log-level")
+ logConfPath := c.String("log-config")
+ bootstrap := config.Load(configPath)
+ if logLevel, ok := flagToLogLevel[flagLogLevel]; ok {
+ logger.SetLoggerLevel(logLevel)
+ }
+ logger.InitLog(logConfPath)
+ if err := GetAPIConfig(bootstrap, apiConfigPath); err != nil {
+ return err
+ }
+ InitNumCPU(c)
+ pixiu.Start(bootstrap)
+ return nil
+}
+
+func GetAPIConfig(bootstrap *model.Bootstrap, apiConfigPath string) error {
Review comment:
func GetAPIConfig(bootstrap *model.Bootstrap, apiConfigPath string)
error {
metaConfig := bootstrap.GetAPIMetaConfig()
if metaConfig == nil {
if _, err := config.LoadAPIConfigFromFile(apiConfigPath); err
!= nil {
logger.Errorf("load api config error:%+v", err)
return err
}
return nil
}
if _, err := config.LoadAPIConfig(bootstrap.GetAPIMetaConfig()); err !=
nil {
logger.Errorf("load api config from etcd error:%+v", err)
return err
}
return nil
}
##########
File path: cmd/pixiu/control.go
##########
@@ -133,3 +97,47 @@ var (
},
}
)
+
+func PixiuAction(c *cli.Context) error {
+ configPath := c.String("config")
+ apiConfigPath := c.String("api-config")
+ flagLogLevel := c.String("log-level")
+ logConfPath := c.String("log-config")
+ bootstrap := config.Load(configPath)
+ if logLevel, ok := flagToLogLevel[flagLogLevel]; ok {
+ logger.SetLoggerLevel(logLevel)
+ }
+ logger.InitLog(logConfPath)
+ if err := GetAPIConfig(bootstrap, apiConfigPath); err != nil {
+ return err
+ }
+ InitNumCPU(c)
+ pixiu.Start(bootstrap)
+ return nil
+}
+
+func GetAPIConfig(bootstrap *model.Bootstrap, apiConfigPath string) error {
Review comment:
```go
func GetAPIConfig(bootstrap *model.Bootstrap, apiConfigPath string) error {
metaConfig := bootstrap.GetAPIMetaConfig()
if metaConfig == nil {
if _, err := config.LoadAPIConfigFromFile(apiConfigPath); err
!= nil {
logger.Errorf("load api config error:%+v", err)
return err
}
return nil
}
if _, err := config.LoadAPIConfig(bootstrap.GetAPIMetaConfig()); err !=
nil {
logger.Errorf("load api config from etcd error:%+v", err)
return err
}
return nil
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
