zouyx commented on a change in pull request #1182:
URL: https://github.com/apache/dubbo-go/pull/1182#discussion_r622693587
##########
File path: common/constant/default.go
##########
@@ -94,3 +94,14 @@ const (
DEFAULT_LOG_CONF_FILE_PATH = "../profiles/dev/log.yml"
DEFAULT_ROUTER_CONF_FILE_PATH = "../profiles/dev/router.yml"
)
+
+// default config value
+const (
+ DEFAULT_REGISTRY_ZK_ID = "demoZK"
+ DEFAULT_REGISTRY_ZK_PROTOCOL = "zookeeper"
+ DEFAULT_REGISTRY_ZK_TIMEOUT = "3s"
+ DEFAULT_REGISTRY_ZK_ADDRESS = "127.0.0.1:2181"
+
+ DEFAULT_PROTOCOL_DUBBO_NAME = "dubbo"
+ DEFAULT_PROTOCOL_DUBBO_PORT = "20000"
Review comment:
default
port：https://github.com/apache/dubbo-go/blob/260fde4ad23d6cd9cb421cc6b9753ca01249e73f/common/constant/default.go#L47
##########
File path: common/constant/default.go
##########
@@ -94,3 +94,14 @@ const (
DEFAULT_LOG_CONF_FILE_PATH = "../profiles/dev/log.yml"
DEFAULT_ROUTER_CONF_FILE_PATH = "../profiles/dev/router.yml"
)
+
+// default config value
+const (
+ DEFAULT_REGISTRY_ZK_ID = "demoZK"
+ DEFAULT_REGISTRY_ZK_PROTOCOL = "zookeeper"
Review comment:
use exist key like
```
DEFAULT_REGISTRY_ZK_PROTOCOL = ZOOKEEPER_KEY
```
reference：https://github.com/apache/dubbo-go/blob/260fde4ad23d6cd9cb421cc6b9753ca01249e73f/common/constant/key.go#L188
##########
File path: common/constant/default.go
##########
@@ -94,3 +94,14 @@ const (
DEFAULT_LOG_CONF_FILE_PATH = "../profiles/dev/log.yml"
DEFAULT_ROUTER_CONF_FILE_PATH = "../profiles/dev/router.yml"
)
+
+// default config value
+const (
+ DEFAULT_REGISTRY_ZK_ID = "demoZK"
+ DEFAULT_REGISTRY_ZK_PROTOCOL = "zookeeper"
+ DEFAULT_REGISTRY_ZK_TIMEOUT = "3s"
+ DEFAULT_REGISTRY_ZK_ADDRESS = "127.0.0.1:2181"
+
+ DEFAULT_PROTOCOL_DUBBO_NAME = "dubbo"
Review comment:
default
protocol：https://github.com/apache/dubbo-go/blob/260fde4ad23d6cd9cb421cc6b9753ca01249e73f/common/constant/default.go#L38
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
