kezhenxu94 commented on pull request #166: URL: https://github.com/apache/dubbo-go-pixiu/pull/166#issuecomment-839772566
> > I'd rather extract the variable as a build argument, otherwise, this kind of issue is highly possible to occur next time > > So we should put variables like this into config file in the future, right? Should I fix it? What I mean is a build argument, not configuration file, take the below as an example https://github.com/apache/skywalking-cli/blob/d06d1ebf565756885650061ddd2e1fe527417052/cmd/swctl/main.go#L43 https://github.com/apache/skywalking-cli/blob/d06d1ebf565756885650061ddd2e1fe527417052/Makefile#L18 https://github.com/apache/skywalking-cli/blob/d06d1ebf565756885650061ddd2e1fe527417052/Makefile#L40 https://github.com/apache/skywalking-cli/blob/d06d1ebf565756885650061ddd2e1fe527417052/Makefile#L71 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
