ztelur opened a new pull request #1218: URL: https://github.com/apache/dubbo-go/pull/1218
<!-- Thanks for sending a pull request! Read https://github.com/apache/dubbo-go/blob/master/contributing.md before commit pull request. --> **What this PR does**: - application service discovery support nacos reporter - reference_config ProvidedBy definition change **why change reference_config ProvidedBy definition**: - there is a misspell, so I change it from "provide-by" to "provided_by" according to constant/key.PROVIDER_BY values and dubbo java param "provided-by". - dubbo-go-samples client.yaml is all wrong related to this param, so application service discovery will fail when client search server metadata info beacause the param is always empty. - the fact which registry/servicediscovery/zookeeper works successfully is coincident，because applicationName in client.yaml is same with applicationName in server.yaml and serviceDiscoveryRegistry.getServices function will return applicationName as default value when providerBy param is empty **Special notes for your reviewer**: - dubbo-go-samples which contains nacos example and zookeeper conf yaml file changes will open a pull request after this merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
