[GitHub] [dubbo-go] jack15083 commented on a change in pull request #1225: fix issue 1166: treat all zk child path url as new child

Mon, 31 May 2021 21:46:57 -0700 


jack15083 commented on a change in pull request #1225:
URL: https://github.com/apache/dubbo-go/pull/1225#discussion_r642468793



##########
File path: remoting/zookeeper/listener.go
##########
@@ -160,10 +160,6 @@ func (l *ZkEventListener) handleZkNodeEvent(zkPath string, 
children []string, li
                newNode string
        )
        for _, n := range newChildren {
-               if contains(children, n) {

Review comment:
       这里去掉的话可能会造成goroutine 开启的过多吧 ， 应该把之前监听的goroutine 关闭
   
   
![image](https://user-images.githubusercontent.com/2142066/120196347-5854ee80-c252-11eb-8a3e-e359af23cd1f.png)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to