LaurenceLiZhixin commented on a change in pull request #134:
URL: https://github.com/apache/dubbo-go-samples/pull/134#discussion_r650489806
##########
File path: general/dubbo3/hessian2/go-server/pkg/greeter.go
##########
@@ -36,14 +35,15 @@ type User struct {
Id string
Name string
Age int32
+ Time time.Time
Review comment:
为什么要加这个字段？java例子的User对象并没给这个字段
##########
File path: general/dubbo3/hessian2/go-server/tests/integration/main_test.go
##########
@@ -24,18 +24,24 @@ import (
"os"
"testing"
"time"
-)
-import (
hessian "github.com/apache/dubbo-go-hessian2"
+
Review comment:
这里无需这么多空行
##########
File path: general/dubbo3/hessian2/go-server/pkg/greeter.go
##########
@@ -19,11 +19,10 @@ package pkg
import (
"context"
-)
-import (
- "github.com/dubbogo/gost/log"
-)
-import (
+ "time"
Review comment:
dubbo-go开发需要遵循三个import block，分别是”基础库“ ”第三方库“ ”本包的库” 可以参考一下其他文件。
##########
File path: general/dubbo3/hessian2/go-client/conf/client.yml
##########
@@ -29,4 +29,4 @@ references:
registry: "demoZk"
protocol: "tri"
serialization: "hessian2"
- interface: "com.apache.dubbo.sample.basic.IGreeter"
Review comment:
为什么这么改？这样会影响和同一例子和java的互通性。
##########
File path: general/dubbo3/hessian2/go-client/conf/client.yml
##########
@@ -29,4 +29,4 @@ references:
registry: "demoZk"
protocol: "tri"
serialization: "hessian2"
- interface: "com.apache.dubbo.sample.basic.IGreeter"
Review comment:
我看了下，这里貌似是hessian2/go-server/conf/client.yml错了，对你进行了误导。
在IDE上运行时，client会以go-client/conf/client.yml作为配置，server会以go-server/conf/server.yml作为配置。
go-server/conf/client.yml是集成测试用的，目前还没支持，我将修复这一问题，并增加triple相关所有集成测试。
##########
File path: general/dubbo3/hessian2/go-server/pkg/greeter.go
##########
@@ -36,14 +35,15 @@ type User struct {
Id string
Name string
Age int32
+ Time time.Time
Review comment:
这里我删掉吧
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
