xavier-niu commented on a change in pull request #1271:
URL: https://github.com/apache/dubbo-go/pull/1271#discussion_r655942535
##########
File path: filter/filter_impl/generic_service_filter.go
##########
@@ -60,39 +59,53 @@ func (ef *GenericServiceFilter) Invoke(ctx context.Context,
invoker protocol.Inv
if invocation.MethodName() != constant.GENERIC ||
len(invocation.Arguments()) != 3 {
return invoker.Invoke(ctx, invocation)
}
+ logger.Debugf("[Generic Service Filter] arguments: %v",
invocation.Arguments())
+ logger.Debugf("[Generic Service Filter] attachments: %v",
invocation.Attachments())
Review comment:
IMO, the two lines for logger could be merged into one line.
##########
File path: filter/filter_impl/generic_filter.go
##########
@@ -19,6 +19,7 @@ package filter_impl
import (
"context"
+ "dubbo.apache.org/dubbo-go/v3/common/logger"
Review comment:
move to 3rd import block
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
