zhangshen023 commented on a change in pull request #169:
URL: https://github.com/apache/dubbo-go-pixiu/pull/169#discussion_r656728346
##########
File path: pkg/filter/ratelimit/logger_warpper.go
##########
@@ -0,0 +1,62 @@
+/*
Review comment:
what does this code make sense?
##########
File path: pkg/filter/ratelimit/matcher/exact.go
##########
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package matcher
+
+import (
+ "github.com/dubbogo/dubbo-go-pixiu-filter/pkg/api/config/ratelimit"
+)
+
+import (
+ "sync"
+)
+
+type Exact struct {
+ apiNames map[string]string
+
+ mu sync.RWMutex
Review comment:
FYI,I think pointer is better
##########
File path: pkg/filter/plugins/plugins.go
##########
@@ -165,7 +189,7 @@ func getAPIFilterFuncsWithPluginsGroup(plu
*config.PluginsInUse) []context.Filte
// found with group name
for _, groupName := range plu.GroupNames {
- pwfMap, found := groupWithPluginsMap[groupName]
+ pwfMap, found := groupCache[groupName]
if found {
Review comment:
` if !found {
continue
}
for _, pwf := range pwfMap {
tmpMap[pwf.Name] = pwf.fn
}
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
