AlexStocks commented on a change in pull request #1272:
URL: https://github.com/apache/dubbo-go/pull/1272#discussion_r656774735
##########
File path: config/config_center_config.go
##########
@@ -45,20 +45,20 @@ import (
// ConfigCenter has currently supported Zookeeper, Nacos, Etcd, Consul, Apollo
type ConfigCenterConfig struct {
//context context.Context
- Protocol string `required:"true" yaml:"protocol"
json:"protocol,omitempty"`
- Address string `yaml:"address" json:"address,omitempty"`
- Cluster string `yaml:"cluster" json:"cluster,omitempty"`
- Group string `default:"dubbo" yaml:"group"
json:"group,omitempty"`
- Username string `yaml:"username" json:"username,omitempty"`
- Password string `yaml:"password" json:"password,omitempty"`
- LogDir string `yaml:"log_dir" json:"log_dir,omitempty"`
- ConfigFile string `default:"dubbo.properties" yaml:"config_file"
json:"config_file,omitempty"`
- Namespace string `default:"dubbo" yaml:"namespace"
json:"namespace,omitempty"`
- AppConfigFile string `default:"dubbo.properties" yaml:"app_config_file"
json:"app_config_file,omitempty"`
- AppId string `default:"dubbo" yaml:"app_id"
json:"app_id,omitempty"`
- TimeoutStr string `yaml:"timeout" json:"timeout,omitempty"`
- RemoteRef string `required:"false" yaml:"remote_ref"
json:"remote_ref,omitempty"`
- //timeout time.Duration
+ Protocol string `required:"true" yaml:"protocol"
json:"protocol,omitempty"`
+ Address string `yaml:"address"
json:"address,omitempty"`
+ Cluster string `yaml:"cluster"
json:"cluster,omitempty"`
+ Group string `default:"dubbo" yaml:"group"
json:"group,omitempty"`
+ Username string `yaml:"username"
json:"username,omitempty"`
+ Password string `yaml:"password"
json:"password,omitempty"`
+ LogDir string `yaml:"log_dir"
json:"log_dir,omitempty"`
+ ConfigFile string `default:"dubbo.properties"
yaml:"config_file" json:"config_file,omitempty"`
+ Namespace string `default:"dubbo" yaml:"namespace"
json:"namespace,omitempty"`
+ AppConfigFile string `default:"dubbo.properties"
yaml:"app_config_file" json:"app_config_file,omitempty"`
+ AppId string `default:"dubbo" yaml:"app_id"
json:"app_id,omitempty"`
Review comment:
AppID
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
