kylixs commented on a change in pull request #8122:
URL: https://github.com/apache/dubbo/pull/8122#discussion_r656879418
##########
File path:
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/bootstrap/DubboBootstrap.java
##########
@@ -1583,4 +1585,11 @@ public ApplicationConfig getApplication() {
return configManager.getApplicationOrElseThrow();
}
+ public void setTakeoverState(BootstrapTakeoverMode takeoverState) {
+ this.takeoverState = takeoverState;
+ }
+
+ public BootstrapTakeoverMode getTakeoverState() {
Review comment:
rename to getTakeoverMode
##########
File path:
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/bootstrap/DubboBootstrap.java
##########
@@ -1583,4 +1585,11 @@ public ApplicationConfig getApplication() {
return configManager.getApplicationOrElseThrow();
}
+ public void setTakeoverState(BootstrapTakeoverMode takeoverState) {
Review comment:
Please rename method `setTakeoverState` to `setTakeoverMode`
##########
File path:
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/bootstrap/DubboBootstrap.java
##########
@@ -148,6 +148,8 @@
private final AtomicBoolean awaited = new AtomicBoolean(false);
+ private volatile BootstrapTakeoverMode takeoverState =
BootstrapTakeoverMode.AUTO;
Review comment:
Please rename field `takeoverState` to `takeoverMode`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
