zhangyz-hd opened a new pull request #8189: URL: https://github.com/apache/dubbo/pull/8189
消费者端ExecutorService在运行期间不应该shutdown 复现了 #8172 的的一种场景 1，启动3个提供者 2，启动1个消费者，开始服务调用 3，kill -9 提供者1，会发现消费者全局ExecutorService被CLOSE，后续服务调用使用SHARED_EXECUTOR 4，kill -9 提供者2，会发现SHARED_EXECUTOR被CLOSE 5，后续服务调用，报错及堆栈基本同issue描述 分析：提供者非正常下线（如netty先关闭，注册中心服务尚未下线），消费者端netty触发AbstractChannelHandlerDelegate.disconnected，从而触发futureExecutor.shutdownNow()。 而消费者端服务调用线程池是全局共享，在运行期间不应该被shutdown。 ## Brief changelog DefaultFuture. closeChannel时，不关闭ExecutorService。 <!-- Follow this checklist to help us incorporate your contribution quickly and easily: --> ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7 - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature. - [ ] GitHub Actions works fine on your own branch. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
