horizonzy commented on a change in pull request #8207:
URL: https://github.com/apache/dubbo/pull/8207#discussion_r663355750
##########
File path:
dubbo-container/dubbo-container-api/src/main/java/org/apache/dubbo/container/Main.java
##########
@@ -61,9 +61,10 @@ public static void main(String[] args) {
final List<Container> containers = new ArrayList<Container>();
for (int i = 0; i < args.length; i++) {
Container container = LOADER.getExtension(args[i]);
- if (null != container) {
- containers.add(LOADER.getExtension(args[i]));
+ if (null == container) {
+ throw new IllegalArgumentException("Default extension is
not configured, but the extension name is 'true'");
Review comment:
msg can be String.format("The extension is not find, pls check your
param: %s is match spi", args[i]);
##########
File path:
dubbo-container/dubbo-container-api/src/main/java/org/apache/dubbo/container/Main.java
##########
@@ -61,9 +61,10 @@ public static void main(String[] args) {
final List<Container> containers = new ArrayList<Container>();
for (int i = 0; i < args.length; i++) {
Container container = LOADER.getExtension(args[i]);
- if (null != container) {
- containers.add(LOADER.getExtension(args[i]));
+ if (null == container) {
+ throw new IllegalArgumentException("Default extension is
not configured, but the extension name is 'true'");
}
+ containers.add(LOADER.getExtension(args[i]));
Review comment:
here can reuse container
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
