horizonzy commented on a change in pull request #8211:
URL: https://github.com/apache/dubbo/pull/8211#discussion_r663684902
##########
File path:
dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/api/Connection.java
##########
@@ -149,14 +153,16 @@ public void onGoaway(Channel channel) {
public void onConnected(Channel channel) {
this.channel.set(channel);
+ this.onConnectFuture.complete(new Object());
channel.attr(CONNECTION).set(this);
if (logger.isInfoEnabled()) {
logger.info(String.format("%s connected ", this));
}
}
- public void connectSync() {
+ public void connectSync() throws InterruptedException, ExecutionException,
TimeoutException {
this.initPromise.awaitUninterruptibly(this.connectTimeout);
+ this.onConnectFuture.get(this.connectTimeout, TimeUnit.MILLISECONDS);
Review comment:
Maybe say sry jiangxch, this pr is duplicated with #8126, thanks for
your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
