CrazyHZM commented on a change in pull request #8116:
URL: https://github.com/apache/dubbo/pull/8116#discussion_r673075159
##########
File path:
dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/api/PortUnificationServerHandler.java
##########
@@ -76,41 +70,28 @@ protected void decode(ChannelHandlerContext ctx, ByteBuf
in, List<Object> out) t
return;
}
- if (isSsl(in)) {
- enableSsl(ctx);
- } else {
- for (final WireProtocol protocol : protocols) {
- in.markReaderIndex();
- final ProtocolDetector.Result result =
protocol.detector().detect(ctx, in);
- in.resetReaderIndex();
- switch (result) {
- case UNRECOGNIZED:
- continue;
- case RECOGNIZED:
- protocol.configServerPipeline(ctx.pipeline(), null);
- ctx.pipeline().remove(this);
- case NEED_MORE_DATA:
- return;
- }
+ for (final WireProtocol protocol : protocols) {
Review comment:
Migrate to SslServerTlsHandler, the reason is to integrate ssl in netty4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
