AlexStocks commented on a change in pull request #234:
URL: https://github.com/apache/dubbo-go-pixiu/pull/234#discussion_r681698436
##########
File path: cmd/pixiu/control.go
##########
@@ -41,99 +45,108 @@ var (
"critical": "FATAL",
}
- cmdStart = cli.Command{
- Name: "start",
- Usage: "start dubbogo pixiu",
- Flags: []cli.Flag{
- cli.StringFlag{
- Name: "config, c",
- Usage: "Load configuration from `FILE`",
- EnvVar: "DUBBOGO_PIXIU_CONFIG",
- Value: "configs/conf.yaml",
- },
- cli.StringFlag{
- Name: "api-config, a",
- Usage: "Load api configuration from `FILE`",
- EnvVar: "DUBBOGO_PIXIU_API_CONFIG",
- Value: "configs/api_config.yaml",
- },
- cli.StringFlag{
- Name: "log-config, lc",
- Usage: "Load log configuration from `FILE`",
- EnvVar: "LOG_FILE",
- Value: "configs/log.yml",
- },
- cli.StringFlag{
- Name: "log-level, l",
- Usage: "dubbogo pixiu log level,
trace|debug|info|warning|error|critical",
- EnvVar: "LOG_LEVEL",
- },
- cli.StringFlag{
- Name: "log-format, lf",
- Usage: "dubbogo pixiu log format, currently
useless",
- },
- cli.StringFlag{
- Name: "limit-cpus, limc",
- Usage: "dubbogo pixiu schedule threads count",
- },
- },
- Action: func(c *cli.Context) error {
- configPath := c.String("config")
- apiConfigPath := c.String("api-config")
- flagLogLevel := c.String("log-level")
- logConfPath := c.String("log-config")
+ configPath string
+ apiConfigPath string
+ logConfigPath string
+ logLevel string
+
+ // CURRENTLY USELESS
+ logFormat string
+
+ limitCpus string
- err := logger.InitLog(logConfPath)
+ // Currently default set to false, wait for up coming support
+ initFromRemote = false
+
+ startCmd = &cobra.Command{
Review comment:
不要用 startCmd，改成 startGatewayCmd，启动命令改成 --start-gateway，为将来 sidecar 模式留下空间
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
