AlbumenJ commented on a change in pull request #8441:
URL: https://github.com/apache/dubbo/pull/8441#discussion_r686485449
##########
File path:
dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/loadbalance/ShortestResponseLoadBalance.java
##########
@@ -36,6 +42,46 @@
public static final String NAME = "shortestresponse";
+ private static final int SLIDE_PERIOD =
Integer.parseInt(System.getProperty("ShortestResponseLoadBalance.slidePeriod",
"30000"));
+
+ private ConcurrentMap<RpcStatus, SlideWindowData> methodMap = new
ConcurrentHashMap<>();
+
+ private AtomicBoolean onResetSlideWindow = new AtomicBoolean(false);
+
+ private volatile long lastUpdateTime = System.currentTimeMillis();
+
+ protected static class SlideWindowData {
+ private final static ExecutorService EXECUTOR_SERVICE =
Executors.newSingleThreadExecutor();
Review comment:
add ThreadFactory for this executor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]