Mulavar commented on a change in pull request #1388:
URL: https://github.com/apache/dubbo-go/pull/1388#discussion_r691742304



##########
File path: remoting/getty/config.go
##########
@@ -29,6 +29,11 @@ import (
        "github.com/apache/dubbo-go/config"
 )
 
+const (
+       TCP_READ_TIMEOUT_MIN_VALUE  = time.Second * 1
+       TCP_WRITE_TIMEOUT_MIN_VALUE = time.Second * 5

Review comment:
       tcp write timeout 默认值是 5s,但是 getty 同样是小于 1s 报 panic,最小值设置为 5s 的考虑是什么?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to