[GitHub] [dubbo-go] Mulavar commented on a change in pull request #1388: Fix: fix the exception when tcp timeout is less than 1s for 1.5 #1362

Thu, 19 Aug 2021 05:08:29 -0700 


Mulavar commented on a change in pull request #1388:
URL: https://github.com/apache/dubbo-go/pull/1388#discussion_r692049614



##########
File path: remoting/getty/config.go
##########
@@ -29,6 +29,11 @@ import (
        "github.com/apache/dubbo-go/config"
 )
 
+const (
+       TCP_READ_TIMEOUT_MIN_VALUE  = time.Second * 1
+       TCP_WRITE_TIMEOUT_MIN_VALUE = time.Second * 5

Review comment:
       默认值是5s不代表最小5s吧，你这个问题不是为了解决getty参数设置过小panic的问题么，关于那个issue的原因是小于1s导致panic。
   getty 里有单测是可以找到设置 write timeout 为 3s 的 case。
   因此我建议这里用 1s 会更合适。
   
![image](https://user-images.githubusercontent.com/23017406/130065726-71cef621-8afd-46be-9e7c-2d6230b3c4e4.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to