xavier-niu commented on a change in pull request #1380:
URL: https://github.com/apache/dubbo-go/pull/1380#discussion_r692616901
##########
File path: remoting/getty/config.go
##########
@@ -177,6 +182,23 @@ func (c *GettySessionParam) CheckValidity() error {
return nil
}
+func parseTimeDurationByRange(timeStr string, min *time.Duration, max
*time.Duration) (time.Duration, error) {
Review comment:
What if the value of `min` or `max` is less than 0? The boundary
conditions should be fully considered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
