xavier-niu commented on a change in pull request #1370:
URL: https://github.com/apache/dubbo-go/pull/1370#discussion_r692636887
##########
File path: config/config_loader.go
##########
@@ -59,6 +59,8 @@ var (
confBaseFile string
uniformVirtualServiceConfigPath string
uniformDestRuleConfigPath string
+
+ loaderHooks map[string][]LoaderHook
Review comment:
Why not initializes `loaderHooks` here? If not initializes, you should
handle the case that `loaderHooks` is empty in `AddLoaderHooks` and
`RemoveLoaderHooks` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
