chickenlj commented on a change in pull request #8566:
URL: https://github.com/apache/dubbo/pull/8566#discussion_r693687580
##########
File path: compiler/src/main/resources/Dubbo3InterfaceStub.mustache
##########
@@ -18,11 +18,37 @@ static final String SERVICE_NAME =
"{{commonPackageName}}.{{serviceName}}";
// FIXME, initialize Dubbo3 stub when interface loaded, thinking of new
ways doing this.
static final boolean inited = {{className}}.init();
-{{#methods}}
+{{#unaryMethods}}
+ {{#javaDoc}}
+ {{{javaDoc}}}
+ {{/javaDoc}}
+ {{#deprecated}}
+ @java.lang.Deprecated
+ {{/deprecated}}
{{outputType}} {{methodName}}({{inputType}} request);
CompletableFuture<{{outputType}}> {{methodName}}Async({{inputType}}
request);
-{{/methods}}
+{{/unaryMethods}}
+
+{{#serverStreamingMethods}}
+ {{#javaDoc}}
+ {{{javaDoc}}}
+ {{/javaDoc}}
+ {{#deprecated}}
+ @java.lang.Deprecated
+ {{/deprecated}}
+ void {{methodName}}({{inputType}} request,
org.apache.dubbo.common.stream.StreamObserver<{{outputType}}> responseObserver);
+{{/serverStreamingMethods}}
+
+{{#biStreamingMethods}}
+ {{#javaDoc}}
+ {{{javaDoc}}}
+ {{/javaDoc}}
+ {{#deprecated}}
+ @java.lang.Deprecated
+ {{/deprecated}}
+ org.apache.dubbo.common.stream.StreamObserver<{{inputType}}>
{{methodName}}(org.apache.dubbo.common.stream.StreamObserver<{{outputType}}>
responseObserver);
+{{/biStreamingMethods}}
Review comment:
Sure we can let the Provider decide to only support unary or streaming
or bi streaming, but is that necessary, or at least whey they want to choose
they don't need to give the implementation of all kinds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
