cjphaha commented on a change in pull request #1372:
URL: https://github.com/apache/dubbo-go/pull/1372#discussion_r695098961



##########
File path: config/config_loader.go
##########
@@ -56,6 +56,8 @@ var (
 
        maxWait        = 3
        confRouterFile string
+
+       loaderHooks map[string][]LoaderHook

Review comment:
       看代码中只有 AddLoaderHooks 函数对loaderHooks 进行初始化,但是 AddLoaderHooks 
只被写在了单测里,是否需要在这里进行初始化会更好一些?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to