LaurenceLiZhixin commented on a change in pull request #215:
URL: https://github.com/apache/dubbo-go-samples/pull/215#discussion_r699230839
##########
File path: build/Makefile
##########
@@ -116,9 +120,12 @@ clean: stop
## start: Start the application (for server)
.PHONY: start
-start: export CONF_PROVIDER_FILE_PATH ?= $(OUT_DIR)/conf/server.yml
+#start: export CONF_PROVIDER_FILE_PATH ?= $(OUT_DIR)/conf/server.yml
Review comment:
感觉这些可以删掉了
##########
File path: build/Makefile
##########
@@ -73,39 +76,40 @@ build: $(OUT_DIR)/$(PROJECT_NAME)$(EXT_NAME) config
.PHONY: $(OUT_DIR)/$(PROJECT_NAME)$(EXT_NAME)
$(OUT_DIR)/$(PROJECT_NAME)$(EXT_NAME):
- $(info > Buiding application binary:
$(OUT_DIR)/$(PROJECT_NAME)$(EXT_NAME))
+ $(info > Buiding application binary:
$(OUT_DIR)/$(PROJECT_NAME)$(EXT_NAME) : $(PROJECT_NAME))
+ $(info > $(DUBBO_GO_CONFIG_PATH))
@CGO_ENABLED=$(CGO) GOOS=$(GOOS) GOARCH=$(GOARCH) go build $(GCFLAGS)
-ldflags=$(LDFLAGS) -i -o $(OUT_DIR)/$(PROJECT_NAME)$(EXT_NAME) $(SOURCES)
## config: Setup config files
.PHONY: config
config:
$(info > Setting up config files)
- @mkdir -p $(OUT_DIR)/conf
- @-test -f $(PROJECT_DIR)/conf/log.yml && cat
$(PROJECT_DIR)/conf/log.yml | sed "s#\$$HOST_IP#$(DOCKER_HOST_IP)#g" >
$(OUT_DIR)/conf/log.yml && echo " > $(OUT_DIR)/conf/log.yml"
- @-test -f $(PROJECT_DIR)/conf/server.yml && cat
$(PROJECT_DIR)/conf/server.yml | sed "s#\$$HOST_IP#$(DOCKER_HOST_IP)#g" >
$(OUT_DIR)/conf/server.yml && echo " > $(OUT_DIR)/conf/server.yml"
- @-test -f $(PROJECT_DIR)/conf/client.yml && cat
$(PROJECT_DIR)/conf/client.yml | sed "s#\$$HOST_IP#$(DOCKER_HOST_IP)#g" >
$(OUT_DIR)/conf/client.yml && echo " > $(OUT_DIR)/conf/client.yml"
- @-test -f $(PROJECT_DIR)/conf/router_config.yml && cat
$(PROJECT_DIR)/conf/router_config.yml | sed "s#\$$HOST_IP#$(DOCKER_HOST_IP)#g"
> $(OUT_DIR)/conf/router_config.yml && echo " >
$(OUT_DIR)/conf/router_config.yml"
- @-test -f $(PROJECT_DIR)/conf/virtual_service.yml && cat
$(PROJECT_DIR)/conf/virtual_service.yml | sed
"s#\$$HOST_IP#$(DOCKER_HOST_IP)#g" > $(OUT_DIR)/conf/virtual_service.yml &&
echo " > $(OUT_DIR)/conf/virtual_service.yml"
- @-test -f $(PROJECT_DIR)/conf/dest_rule.yml && cat
$(PROJECT_DIR)/conf/dest_rule.yml | sed "s#\$$HOST_IP#$(DOCKER_HOST_IP)#g" >
$(OUT_DIR)/conf/dest_rule.yml && echo " > $(OUT_DIR)/conf/dest_rule.yml"
+# @mkdir -p $(OUT_DIR)/conf
+# @-test -f $(PROJECT_DIR)/conf/log.yml && cat
$(PROJECT_DIR)/conf/log.yml | sed "s#\$$HOST_IP#$(DOCKER_HOST_IP)#g" >
$(OUT_DIR)/conf/log.yml && echo " > $(OUT_DIR)/conf/log.yml"
Review comment:
这块是不是也可以删掉了。其他我没意见
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
