guohao commented on a change in pull request #8712:
URL: https://github.com/apache/dubbo/pull/8712#discussion_r704002686
##########
File path:
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/UnaryServerStream.java
##########
@@ -114,28 +117,28 @@ public void invoke() {
final byte[] data;
try {
ClassLoadUtil.switchContextLoader(
-
getProviderModel().getServiceInterfaceClass().getClassLoader());
+
getProviderModel().getServiceInterfaceClass().getClassLoader());
data = encodeResponse(response.getValue());
} finally {
ClassLoadUtil.switchContextLoader(tccl);
}
getTransportSubscriber().onData(data, false);
Metadata trailers = new DefaultMetadata()
- .put(TripleHeaderEnum.STATUS_KEY.getHeader(),
Integer.toString(GrpcStatus.Code.OK.code));
+ .put(TripleHeaderEnum.STATUS_KEY.getHeader(),
Integer.toString(GrpcStatus.Code.OK.code));
final Map<String, Object> attachments =
response.getObjectAttachments();
if (attachments != null) {
convertAttachment(trailers, attachments);
}
getTransportSubscriber().onMetadata(trailers, true);
} catch (Throwable e) {
LOGGER.warn("Exception processing triple message", e);
- if (e instanceof TripleRpcException) {
- transportError(((TripleRpcException) e).getStatus(),
response.getObjectAttachments());
+ if (e instanceof RpcException) {
+ transportError(rpcExceptionCodeToGrpc(((RpcException)
e).getCode()), response.getObjectAttachments());
Review comment:
Same issue as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
