cjphaha commented on a change in pull request #245:
URL: https://github.com/apache/dubbo-go-samples/pull/245#discussion_r709817899
##########
File path: tracing/jsonrpc/go-server/cmd/server.go
##########
@@ -26,82 +26,87 @@ import (
)
import (
- _ "dubbo.apache.org/dubbo-go/v3/cluster/cluster_impl"
- _ "dubbo.apache.org/dubbo-go/v3/cluster/loadbalance"
"dubbo.apache.org/dubbo-go/v3/common/logger"
- _ "dubbo.apache.org/dubbo-go/v3/common/proxy/proxy_factory"
"dubbo.apache.org/dubbo-go/v3/config"
- _ "dubbo.apache.org/dubbo-go/v3/filter/filter_impl"
- _ "dubbo.apache.org/dubbo-go/v3/protocol/jsonrpc"
- _ "dubbo.apache.org/dubbo-go/v3/registry/protocol"
- _ "dubbo.apache.org/dubbo-go/v3/registry/zookeeper"
+ _ "dubbo.apache.org/dubbo-go/v3/imports"
+
+ "github.com/apache/dubbo-go-samples/tracing/jsonrpc/go-server/pkg"
Review comment:
这个放在第三个 import 块比较好
##########
File path: tracing/jsonrpc/go-server/cmd/server.go
##########
@@ -26,82 +26,87 @@ import (
)
import (
- _ "dubbo.apache.org/dubbo-go/v3/cluster/cluster_impl"
- _ "dubbo.apache.org/dubbo-go/v3/cluster/loadbalance"
"dubbo.apache.org/dubbo-go/v3/common/logger"
- _ "dubbo.apache.org/dubbo-go/v3/common/proxy/proxy_factory"
"dubbo.apache.org/dubbo-go/v3/config"
- _ "dubbo.apache.org/dubbo-go/v3/filter/filter_impl"
- _ "dubbo.apache.org/dubbo-go/v3/protocol/jsonrpc"
- _ "dubbo.apache.org/dubbo-go/v3/registry/protocol"
- _ "dubbo.apache.org/dubbo-go/v3/registry/zookeeper"
+ _ "dubbo.apache.org/dubbo-go/v3/imports"
+
+ "github.com/apache/dubbo-go-samples/tracing/jsonrpc/go-server/pkg"
"github.com/opentracing/opentracing-go"
zipkinot "github.com/openzipkin-contrib/zipkin-go-opentracing"
"github.com/openzipkin/zipkin-go"
zipkinhttp "github.com/openzipkin/zipkin-go/reporter/http"
+
+ "github.com/uber/jaeger-client-go"
+ jaegerConfig "github.com/uber/jaeger-client-go/config"
)
var (
survivalTimeout = int(3e9)
)
-// they are necessary:
-// export CONF_PROVIDER_FILE_PATH="xxx"
-// export APP_LOG_CONF_FILE="xxx"
func main() {
-
- config.Load()
-
- initZipkin()
-
+ config.SetProviderService(new(pkg.UserProvider))
+
config.Load(config.WithPath("./tracing/jsonrpc/go-server/conf/dubbogo.yml"))
initSignal()
+ // initJaeger() and initZipkin() can only use one at the same time
+ initJaeger()
Review comment:
initSignal() 写在 initJaeger() 上面会阻塞住 initJaeger() 的运行吧？
##########
File path: tracing/jsonrpc/go-server/cmd/server.go
##########
@@ -26,82 +26,87 @@ import (
)
import (
- _ "dubbo.apache.org/dubbo-go/v3/cluster/cluster_impl"
- _ "dubbo.apache.org/dubbo-go/v3/cluster/loadbalance"
"dubbo.apache.org/dubbo-go/v3/common/logger"
- _ "dubbo.apache.org/dubbo-go/v3/common/proxy/proxy_factory"
"dubbo.apache.org/dubbo-go/v3/config"
- _ "dubbo.apache.org/dubbo-go/v3/filter/filter_impl"
- _ "dubbo.apache.org/dubbo-go/v3/protocol/jsonrpc"
- _ "dubbo.apache.org/dubbo-go/v3/registry/protocol"
- _ "dubbo.apache.org/dubbo-go/v3/registry/zookeeper"
+ _ "dubbo.apache.org/dubbo-go/v3/imports"
+
+ "github.com/apache/dubbo-go-samples/tracing/jsonrpc/go-server/pkg"
"github.com/opentracing/opentracing-go"
zipkinot "github.com/openzipkin-contrib/zipkin-go-opentracing"
"github.com/openzipkin/zipkin-go"
zipkinhttp "github.com/openzipkin/zipkin-go/reporter/http"
+
+ "github.com/uber/jaeger-client-go"
+ jaegerConfig "github.com/uber/jaeger-client-go/config"
)
var (
survivalTimeout = int(3e9)
)
-// they are necessary:
-// export CONF_PROVIDER_FILE_PATH="xxx"
-// export APP_LOG_CONF_FILE="xxx"
func main() {
-
- config.Load()
-
- initZipkin()
-
+ config.SetProviderService(new(pkg.UserProvider))
+
config.Load(config.WithPath("./tracing/jsonrpc/go-server/conf/dubbogo.yml"))
Review comment:
这里不建议写成固定的，可以参照 .run/dubbo-context-server.xml.run 文件，在 .run 目录里面修改
jsonrpc tracing sample 相应的配置文件，然后这里面设置路径
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
