zrlw edited a comment on pull request #8872:
URL: https://github.com/apache/dubbo/pull/8872#issuecomment-924964900


   maybe we should revert #7410, because i debug 
ReferenceCountExchangeClientTest test_counter_error() as junit test,
   it showed that:
   ```
           client.close();  <== call HeaderExchangeChannel close() directly !!!
   
           // client has been replaced with lazy client. lazy client is fetched 
from referenceclientmap, and since it's
           // been invoked once, it's close status is false
           Assertions.assertFalse(client.isClosed(), "client status close");
           Assertions.assertFalse(helloServiceInvoker.isAvailable(), "client 
status close");
   ```
   close() method will be called directly, closed variable should not set true 
at close() function, otherwise close(int timeout) will not be called and the 
status of the invoker will keep available.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to