kevinw66 commented on a change in pull request #8785:
URL: https://github.com/apache/dubbo/pull/8785#discussion_r714595618
##########
File path:
dubbo-common/src/main/java/org/apache/dubbo/common/utils/MethodUtils.java
##########
@@ -395,4 +396,35 @@ static Method findOverriddenMethod(Method overrider,
Class<?> declaringClass) {
List<Method> matchedMethods = getAllMethods(declaringClass, method ->
overrides(overrider, method));
return matchedMethods.isEmpty() ? null : matchedMethods.get(0);
}
+
+ /**
+ * Extract fieldName from set/get/is method. if it's not a set/get/is
method, return empty string.
+ * If method equals get/is/getClass/getObject, also return empty string.
+ *
+ * @param method method
+ * @return fieldName
+ */
+ static String extractFieldName(Method method) {
Review comment:
done
##########
File path:
dubbo-common/src/test/java/org/apache/dubbo/config/context/ConfigManagerTest.java
##########
@@ -126,6 +126,7 @@ public void tesModuleConfig() {
@Test
public void tesMetricsConfig() {
MetricsConfig config = new MetricsConfig();
+ config.setProtocol("prometheus");
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
