zrlw commented on issue #8895: URL: https://github.com/apache/dubbo/issues/8895#issuecomment-928924025
1. InterfaceCompatibleRegistryProtocol的getInvoker方法先创建Directory，再将其作为参数去创建ClusterInvoker，从逻辑上看销毁ClusterInvoker的Directory的职责应该是ClusterInvoker的destroy方法。 2. MockClusterInvoker既设计了Directory成员，也设计了invoker成员，并且invoker接口没有提供getDirectory的方法，从设计角度看，可以扩展RegistryProtocol协议让不同的invoker共享同一个Directory，类似ReferenceCountExchangeClient那样。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
