dk-lockdown commented on a change in pull request #260:
URL: https://github.com/apache/dubbo-go-pixiu/pull/260#discussion_r717608401
##########
File path: pkg/filter/http/httpproxy/routerfilter.go
##########
@@ -51,15 +51,17 @@ type (
cfg *Config
}
// Config describe the config of Filter
- Config struct{}
+ Config struct {
+ client *http3.Client
Review comment:
不应将整个 http.Client 给用户反序列化配置，用户只需要关注 transport 的内容
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
