LaurenceLiZhixin commented on a change in pull request #1499:
URL: https://github.com/apache/dubbo-go/pull/1499#discussion_r720755633
##########
File path: config/provider_config.go
##########
@@ -35,16 +35,17 @@ type ProviderConfig struct {
Filter string `yaml:"filter" json:"filter,omitempty" property:"filter"`
// Deprecated Register whether registration is required
Register bool `yaml:"register" json:"register" property:"register"`
- // Registry registry ids
- Registry []string `yaml:"registry" json:"registry" property:"registry"`
+ // Registries registry ids TODO Registries?
+ Registries []string `yaml:"registries" json:"registries"
property:"registries"`
Review comment:
IDs 也要用复数吧？
##########
File path: config/provider_config.go
##########
@@ -35,16 +35,17 @@ type ProviderConfig struct {
Filter string `yaml:"filter" json:"filter,omitempty" property:"filter"`
// Deprecated Register whether registration is required
Register bool `yaml:"register" json:"register" property:"register"`
- // Registry registry ids
- Registry []string `yaml:"registry" json:"registry" property:"registry"`
+ // Registries registry ids TODO Registries?
+ Registries []string `yaml:"registries" json:"registries"
property:"registries"`
Review comment:
IDs 也要用复数吧？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
