AlexStocks commented on a change in pull request #1507: URL: https://github.com/apache/dubbo-go/pull/1507#discussion_r725494499
########## File path: cluster/loadbalance/consistenthashing/loadbalance.go ########## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package consistenthashing + +import ( + "encoding/json" + "hash/crc32" + "regexp" +) + +import ( + "dubbo.apache.org/dubbo-go/v3/cluster/loadbalance" + "dubbo.apache.org/dubbo-go/v3/common/constant" + "dubbo.apache.org/dubbo-go/v3/common/extension" + "dubbo.apache.org/dubbo-go/v3/protocol" +) + +const ( + // HashNodes hash nodes + HashNodes = "hash.nodes" + // HashArguments key of hash arguments in url + HashArguments = "hash.arguments" +) + +var ( + selectors = make(map[string]*selector) + re = regexp.MustCompile(constant.COMMA_SPLIT_PATTERN) +) + +func init() { + extension.SetLoadbalance(constant.LoadBalanceKeyConsistentHashing, newLoadBalance) +} + +// loadBalance implementation of load balancing: using consistent hashing +type loadBalance struct{} + +// newLoadBalance creates NewConsistentHashLoadBalance +// +// The same parameters of the request is always sent to the same provider. +func newLoadBalance() loadbalance.LoadBalance { + return &loadBalance{} +} + +// Select gets invoker based on load balancing strategy +func (lb *loadBalance) Select(invokers []protocol.Invoker, invocation protocol.Invocation) protocol.Invoker { + methodName := invocation.MethodName() + key := invokers[0].GetURL().ServiceKey() + "." + methodName + + // hash the invokers + bs := make([]byte, 0) Review comment: 要么写成 “bs := make([]byte)”，要么写成 “bs := make([]byte, 0, len(invokers))" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
