justxuewei commented on a change in pull request #1510:
URL: https://github.com/apache/dubbo-go/pull/1510#discussion_r725784628
##########
File path: cluster/cluster_impl/failover_cluster_invoker.go
##########
@@ -45,6 +45,17 @@ func newFailoverClusterInvoker(directory cluster.Directory)
protocol.Invoker {
}
}
+func getMethodName(invocation protocol.Invocation) string {
+ var methodName = invocation.MethodName()
+ if methodName == constant.GENERIC && len(invocation.Arguments()) > 0 {
Review comment:
Please consider replacing this line with `isGenericInvocation` defined
in `filter/generic/util.go` at line 52 to determine if the invocation is
generic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
