zrlw commented on a change in pull request #9033:
URL: https://github.com/apache/dubbo/pull/9033#discussion_r727972225
##########
File path:
dubbo-configcenter/dubbo-configcenter-zookeeper/src/main/java/org/apache/dubbo/configcenter/support/zookeeper/ZookeeperDynamicConfiguration.java
##########
@@ -83,7 +82,9 @@ public String getInternalProperty(String key) {
@Override
protected void doClose() throws Exception {
- zkClient.close();
+ // TODO zkClient is shared in framework, should not close it here?
+ // zkClient.close();
Review comment:
if SingleRegistryCenterInjvmIntegrationTest (using registry only as
config center testing has no registry) closes zkClient eventually then it is ok
for zookeeper client, but it's just one kind of dynamic configuration.
i think the root cause is dynamic configurations which need to be closed are
not to be closed by now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
