kylixs commented on a change in pull request #9033:
URL: https://github.com/apache/dubbo/pull/9033#discussion_r728586318
##########
File path:
dubbo-configcenter/dubbo-configcenter-zookeeper/src/main/java/org/apache/dubbo/configcenter/support/zookeeper/ZookeeperDynamicConfiguration.java
##########
@@ -83,7 +82,9 @@ public String getInternalProperty(String key) {
@Override
protected void doClose() throws Exception {
- zkClient.close();
+ // TODO zkClient is shared in framework, should not close it here?
+ // zkClient.close();
Review comment:
If application A and B are not shared same FrameworkModel, they use two
isolated Instances of ZookeeperTransporter so that there are no redundant ZK
connections.
If A and B use the same FrameworkModel, it will result in A shared ZK
connections and cannot simply close part of them when application B stopped.
Some ZK connections may be used in both application A and B.
If we want to close ZK connections on application shutdown, we must first
record which applications these ZK connections are used in, and then we can
safely close idle ZK connections. You can submit pr later for fine
application-level ZK connection management.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
