kylixs commented on a change in pull request #9033:
URL: https://github.com/apache/dubbo/pull/9033#discussion_r728694883
##########
File path:
dubbo-configcenter/dubbo-configcenter-zookeeper/src/main/java/org/apache/dubbo/configcenter/support/zookeeper/ZookeeperDynamicConfiguration.java
##########
@@ -82,8 +82,10 @@ public String getInternalProperty(String key) {
@Override
protected void doClose() throws Exception {
- // TODO zkClient is shared in framework, should not close it here?
+ // zkClient is shared in framework, should not close it here
Review comment:
NO. The zk client is shared between `ZookeeperRegistry` ,
`ZookeeperDynamicConfiguration` and `ZookeeperMetadataReport`, if close it in
one place, the other reference use the zk client may throw already destroyed
exeception.
The safe way is close zk clients in ApplicationDeployer.postDestroy()
after release all zk components before `onStopped()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
