justxuewei commented on a change in pull request #1527:
URL: https://github.com/apache/dubbo-go/pull/1527#discussion_r732422356
##########
File path: config/protocol_config.go
##########
@@ -27,9 +27,10 @@ import (
// ProtocolConfig is protocol configuration
type ProtocolConfig struct {
- Name string `required:"true" yaml:"name" json:"name,omitempty"
property:"name"`
- Ip string `required:"true" yaml:"ip" json:"ip,omitempty"
property:"ip"`
- Port string `required:"true" yaml:"port" json:"port,omitempty"
property:"port"`
+ Name string `required:"true" yaml:"name" json:"name,omitempty"
property:"name"`
+ Ip string `required:"true" yaml:"ip" json:"ip,omitempty"
property:"ip"`
Review comment:
IMO, `Ip` should be renamed to `IP`, cc @AlexStocks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
