kylixs commented on a change in pull request #8954:
URL: https://github.com/apache/dubbo/pull/8954#discussion_r735323067
##########
File path:
dubbo-common/src/main/java/org/apache/dubbo/common/timer/HashedWheelTimer.java
##########
@@ -647,6 +679,26 @@ public void expire() {
return;
}
+ // run timeout task at separate thread to avoid the worker thread
blocking
+ try {
+ if (timer.taskExecutor == null) {
+ // the global executor service should be gotten at each
calling to avoid using invalid executor.
+
GlobalResourcesRepository.getGlobalExecutorService().execute(this);
Review comment:
I don't think use global executor service is a good idea. Keep every
component as simple as possible and don't rely on unnecessary components.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
