kylixs commented on a change in pull request #9015:
URL: https://github.com/apache/dubbo/pull/9015#discussion_r738976086
##########
File path:
dubbo-common/src/main/java/org/apache/dubbo/common/config/configcenter/wrapper/CompositeDynamicConfiguration.java
##########
@@ -97,7 +96,9 @@ public void close() throws Exception {
try {
configuration.close();
} catch (Exception e) {
- logger.warn("close dynamic configuration failed: " +
e.getMessage(), e);
+ if (!(e instanceof UnsupportedOperationException)) {
Review comment:
This exception should not be ignored
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
