AlbumenJ commented on pull request #9112: URL: https://github.com/apache/dubbo/pull/9112#issuecomment-958618554
> But the addDisabledInvokers removeDisabledInvokers operations added on the Directory seems a little strange from the design point. I personally think it will be better if Directory itself can take care of the status of all invokers inside while the ClusterInvoker can only interact with the list method and maintain its reselected list or choose to do retry or not in case of RPC failures. `addDisabledInvokers` and `removeDisabledInvokers` are designed for offline notification. For example, server can notify all of the clients that server will be shutdown in moments, and clients should not continue invoke this server any more. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
