guohao commented on a change in pull request #9228:
URL: https://github.com/apache/dubbo/pull/9228#discussion_r744443551
##########
File path:
dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/router/state/StateRouter.java
##########
@@ -91,10 +83,20 @@
*/
boolean isRuntime();
- boolean isEnable();
-
+ /**
+ * To decide whether this router should take effect when none of the
invoker can match the router rule, which
+ * means the {@link #route(BitList, URL, Invocation, boolean)} would be
empty. Most of time, most router implementation would
+ * default this value to false.
+ *
+ * @return true to execute if none of invokers matches the current router
+ */
Review comment:
`isForce` is not a common logic in `AbstractRouter`, can it be removed ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
